[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [cgmo-webcgm] alpha Escape review
The text block in the picture is a nice feature. But I wouldn't reject a test because of its lack. (And it could be a pain to add in some cases.) The harness really enhances usability, and is easy to add. Names: they should ideally be "camel case" -- transCellColor. That should be an easy convention to implement. (I don't much like underscore, as it disappears if the text is underlined, for example if it occurs in a hyperlink.) -Lofton. At 03:36 PM 1/6/2009 -0700, Robert Orosz wrote: >I agree that an HTML harness is a good idea. It was also missing from the >trans-cell-color test that I just reviewed. > >Also, if we are going to standardize on a text block at the bottom of the >picture, there wasn't one in trans-cell-color test either. > >Regarding the test name, it is "trans-cell-color" in the matrix, and files >are name "trans_cell_color" (underscores instead of hyphens). > >Rob > >-----Original Message----- >From: Lofton Henderson [mailto:lofton@rockynet.com] >Sent: Tuesday, January 06, 2009 3:25 PM >To: WebCGM >Subject: Re: [cgmo-webcgm] alpha Escape review > > >At 10:15 AM 12/19/2008 -0800, Galt, Stuart A wrote: > >Hello, > > > >Review of the alphaEscape test > > > >-The test matrix calls out the test as "alpha" and the files are > >"alphaEscape" > >Easiest solution: I changed the matrix. > >Forrest: as test owner, do you agree? > >(All: any comments?) > > >-The test includes a CGM file and a PNG file but does not have a html > >comparison frame like the static 2.0 tests have. > >I think having an HTML presentation file (harness) is a good principle. > >Forrest, all: is there any reason that we should not have it for this test? > >(If 'agreed', then ... Forrest, will you please take care of that detail?) > > >-The design of the test is good. It is easy to tell if the test is > >passed or failed. > >I also looked at the structure of the CGM and it looks like is correct. > > > >I think that if the test had the text block at the bottom and maybe a > >label or two at the opaque and transparent ends. I would also prefer to > >update the name on the test matrix to alphaEscape agree with the file > >names but could go either way. > >That sounds like a good suggestion -- it would make the test more >self-documenting, right? > >Forrest, do you agree, and would you please update the test if so? > >Thanks, >-Lofton. > > >--------------------------------------------------------------------- >To unsubscribe from this mail list, you must leave the OASIS TC that >generates this mail. Follow this link to all your TCs in OASIS at: >https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php > >--------------------------------------------------------------------- >To unsubscribe from this mail list, you must leave the OASIS TC that >generates this mail. Follow this link to all your TCs in OASIS at: >https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]