Re: [dss-x] TAML assertions derived from the core

[Stefan Drees <stefan@drees.name>]

Hi Andreas,

Am 22.01.13 09:49, schrieb Andreas Kuehne:
> ... attached you'll find the assertions I derived from the core spec. As
> mentioned in the call there are just a few assertions in this file. Most
> of the 'work' is done by the XML schema.
> ...

so we all did a near perfect job ;-) years ago ... no schematron 
lightning and thunder necessary, I mean.

Thanks a lot for posting. This mail now primarily services as a ping 
response, that me (and all the others I presume :-) are currently 
reviewing your submission.

First feedback:

I already took a first look (esp. read the comments inside) and

1.

stumbled a bit over the text eg. in XPATH =
/dssCoreSpecification/body[1]/section[1]/*[namespace-uri()='http://docs.oasis-open.org/ns/tag/taml-201002/' 
and 
local-name()='testAssertion'][1]/*[namespace-uri()='http://docs.oasis-open.org/ns/tag/taml-201002/' 
and local-name()='normativeSource'][1]

i.e.:
"The input documents, which the signature will be calculated over.  This 
element, while optional in RequestBaseType, the the client MUST include 
it in a <SignRequest> element."

do I understand it correctly, that the snippet is extracted from our 
spec (the core i.e.) but transformed accordingly (for the vanilla RFC 
2119 compliance (REQUIRED maps to MUST, etc)?

Thus in this case, as the releavant portion of section "[3.1 Element 
<SignRequest>](http://docs.oasis-open.org/dss/v1.0/oasis-dss-core-spec-v1.0-os.html#_Toc159076052)" 
states:

"The input documents, which the signature will be calculated over.  This 
element, while optional in RequestBaseType, is REQUIRED for the 
&lt;SignRequest&gt; element."

should be transformed into text(taml:normativeSource) =
"The input documents, which the signature will be calculated over.  This 
element, while optional in RequestBaseType, MUST be included for the 
&lt;SignRequest&gt; element."

In our scenarios, it is allways the client, being responsible for the 
assemblage of the request, so I do not think, we need to put this detail 
in transcriptions that go into the text content of taml:normativeSource 
Elements.


2.

Also I think the attribute value at XPATH =
/dssCoreSpecification/body[1]/section[1]/*[namespace-uri()='http://docs.oasis-open.org/ns/tag/taml-201002/' 
and local-name()='testAssertion'][1]/@name

should not be
"ensure 'InputDocument' tag is present in a sign request "

but instead maybe:
"ensure 'InputDocuments' tag is present in a sign request"

(note the plural form of the element name.)


Will try to allocate some additional time reviewing, correlating and 
thinking about it next week, so I can give better feedback before our 
next conference call on 2013-02-04.



PS: I noticed and enjoyed, receiving a well-formed xml file. When 
otherwise often receiving ill-formed xml from other parties, I sometimes 
wonder, why the W3C even bothered to define this easy to ensure 
"quality"-level for xml documents in the first place ;-?)

All the best,
Stefan.