Re: [office] Cleaning up angles

[Michael Brauer <michael.brauer@oracle.com>]

Hi Patrick,

Andreas J. Guelzow wrote:
> On Mon, 2010-10-11 at 14:33 -0600, Patrick Durusau wrote:
>> Greetings,
>>
>> While cleaning up values and statements about values, I ran across:
>>
>> 20.2 chart:angle-offset
>>
>>
>>> The default value is 90deg.
>>
>> I assume the value is: 90, meaning 90 degrees. 

No, the value is indeed 90deg. See Andreas analysis below.
>>
>> Yes? 
>>
>> datatype angle
>>
>> See also:
>>
>> 20.75 dr3d.end-angle 
>>
>> "If it is the default (360deg)..."
>>
>> Then just 360 in the rest of that paragraph.
>>
>> datatype is angle.

That all appears to be correct.

>>
>> There are places where we define 0, 0deg, 0grad, etc. as legitimate
>> values. See: 20.287 style:glyph-orientation-vertical, 

Yes, that is in alignment with the angle datatype

>>
>> Actually on style:text-rotation-angle (which provoked all this), I am
>> not sure that it doesn't allow 0 and 0deg. And in the process contradict
>> the schema. 

The attribute allows 0, 90 and 270 (which are interpreted as degrees) 
and angle value that correspond to these values. However, the 
restriction on these value is expressed in the prose but not in the 
schema. That's okay.

>>
>> Thoughts on that one would be appreciated. 
>>
> 
> In 18.3.1 we have:
> An angle is a double value that may be followed immediately by one of
> the following angle unit identifiers: deg (degrees), grad (gradiants) or
> rad (radians). If no unit identifier is specified, the value is assumed
> to be in degrees.
> 
> so so 360deg, 0rad, 1000.5, ... should all be valid. THe schema is
> pretty useless here:
>     <define name="angle">
>         <data type="string"/>
>     </define>
> 
> Note though that style:text-rotation-angle currently does _not_ allow
> arbitrary angles as values:
>                 <attribute name="style:text-rotation-angle">
>                     <choice>
>                         <value>0</value>
>                         <value>90</value>
>                         <value>270</value>
>                         <ref name="angle"/>
>                     </choice>
>                 </attribute>
> 
> I think that is a mistake though. We should allow arbitrary angles here
> too!

We didn't allow arbitrary values in the past. We may extend that, but 
that's something we certainly should not do in the last minute. That is, 
  we should keep the limitation for ODF 1.2, but may discuss for 
ODF-Next whether it is reasonable and should be kept, or whether we want 
to remove it.

I've notices there are some more comments in

http://tools.oasis-open.org/issues/browse/OFFICE-3407

I will reply to these in the issue itself.

Michael


> 
> Andreas
> 
> PS: a separate issue is that an angle by itself does not suffice in any
> or most of these cases. We really should specify which direction is
> 0deg.
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that
> generates this mail.  Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 
> 


-- 
Michael Brauer | Oracle Office Development
Phone: +49 40 23646 500
Oracle Office GBU

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven