RE: [sca-j] Groups - Proposal for ISSUE 130: Problems with Example 3 in

Hi Yang,

Thanks for your proposal for Issue 130.

I’ve had a read of the MS Word version of the proposal and I have updated the MS Word document with the following changes for your review and comment:

Missing import of org.oasisopen.sca.ComponentContext as needed by line 842
Line 854 is wrong as it is attempting to store a ServiceReference returned by createSelfReference() method in a AccountService object.

The line needs to be:

ServiceReference<AccountService> accountService = context.createSelfReference(AccountService.class);

Also need to add import for ServiceReference.

Lines 828 & 829 – the import statements for Context and Property have been merged into one line. They should be split
Lines 854 & 855 – definition of accountService. The line needs to be indented. By 1 space to match the rest of the code in the method. Also, could the line be split so that it does not wrap as this makes it hard to read. i.e. change:

AccountService accountService =

context.createSelfReference(AccountService.class);

To:

AccountService accountService =

context.createSelfReference(AccountService.class);

· Line 867 & 868 needs to be split to improve readability and have its indentation corrected. From

checkingAccountSummary.setAccountNumber(checkingAccount.getAccountNumber()

);

To:

checkingAccountSummary.setAccountNumber(

checkingAccount.getAccountNumber());

Line 871 & 872 need to be split to improve readability. From:

checkingAccountSummary.setBalance(accountService.fromUSDollarToCurrency

(checkingAccount.getBalance()));

To:

checkingAccountSummary.setBalance(

accountService.fromUSDollarToCurrency

(checkingAccount.getBalance()));

At various points through the code, MS Word had done the Smart Quote substitution on you and had changed “ “ to sloping quote characters. See lines 839 & 840 for an example. I have changed these back to normal quotes so the code can be copied into Eclipse.
I’ve put the imports in alphabetical order.

Thanks,

Mark

> -----Original Message-----

> From: yanglei@us.ibm.com [mailto:yanglei@us.ibm.com]

> Sent: 12 February 2009 22:43

> To: sca-j@lists.oasis-open.org

> Subject: [sca-j] Groups - Proposal for ISSUE 130: Problems with Example 3

> in chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded

> The document named Proposal for ISSUE 130: Problems with Example 3 in

> chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) has been submitted

> by Ms. Yang Lei to the OASIS Service Component Architecture / J (SCA-J) TC

> document repository.

> Document Description:

> Thanks Simon for the prior review and comments

> View Document Details:

> http://www.oasis-open.org/committees/document.php?document_id=31205

> Download Document:

> http://www.oasis-open.org/committees/download.php/31205/sca-javacaa-1.1-

> spec-cd02-rev2%2BIssue130.doc

> PLEASE NOTE: If the above links do not work for you, your email

> application

> may be breaking the link into two pieces. You may be able to copy and

> paste

> the entire link address into the address field of your web browser.

> -OASIS Open Administration

sca-j message