[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio] Feedback for CSPRD03
On Tue, 2014-07-22 at 20:25 +0100, Michael S. Tsirkin wrote: > I think the only things left are: > > > * 3.1.2 "Legacy devices do not support the FEATURES_OK status bit, and > > thus did not have a graceful way for the device to indicate > > unsupported > > feature combinations. It also did not provide a clear mechanism to > > end feature negotiation, which meant that devices finalized features > > on > > first-use, and no features could be introduced which radically changed > > the initial operation of the device." > > > > This has mixed tenses ("do not"/"did not"/"which meant"). Probably > > should all be present tense, since all the statements are still true > > of > > legacy devices now as well as in the past. https://issues.oasis-open.org/browse/VIRTIO-112 > > * 4.2 "Therefore most of operations like..." > > > > Should be "Therefore most operations including" The second thing should be actually included in the MMIO fix, will add. Paweł
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]