[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] virtio 1.1 features question
On 6/18/19 9:42 PM, Michael S. Tsirkin wrote:
On Thu, Feb 21, 2019 at 04:47:32PM +0100, Cornelia Huck wrote:On Thu, 21 Feb 2019 10:29:14 -0500 Don Wallwork <don.wallwork@broadcom.com> wrote:Is there an expectation that feature names in the spec would match implementation in code? I presume not, since features like VIRTIO_F_EVENT_IDX and VIRTIO_F_INDIRECT_DESC do not appear in Linux kernel or QEMU code; VIRTIO_RING_F_EVENT_IDX and VIRTIO_RING_F_INDIRECT_DESC are used instead.I'd say matching the names is nice, but not required.Also noticed that there seems to be an inconsistency in the spec in that VIRTIO_F_EVENT_IDX is used in some places and VIRTIO_F_RING_EVENT_IDX is used in others.. Is this intended?This looks like a bug... the same things should use the same names. Might be a good idea to switch both to the name used in Linux/QEMU?I agree. Don would you like to open a github issue so we don't forget to fix this? If you do you get attribution which is nice.
Will do.
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]