[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints
>> + >> +\devicenormative{\paragraph}{Free Page Hinting}{Device Types / Memory Balloon Device / Device Operation / Free Page Hinting} >> + >> +Normative statements in this section apply if the >> +VIRTIO_BALLOON_F_FREE_PAGE_HINT feature has been negotiated. >> + >> +The device MUST set \field{free_page_hint_cmd_id} to >> +VIRTIO_BALLOON_CMD_ID_STOP any time that the dirty pages for the given >> +guest are being recorded. >> + >> +The device MUST NOT reuse a command ID until it has received an output >> +descriptor containing VIRTIO_BALLOON_CMD_ID_STOP from the driver. >> + >> +The device MUST ignore pages that are provided with a command ID that does >> +not match the current value in \field{free_page_hint_cmd_id}. >> + >> +The device MAY modify the contents of the page in the balloon if the page >> +has not been modified by the guest since the \field{free_page_hint_cmd_id} >> +associated with the hint was issued by the device. > > "page in the balloon" -> "previously hinted pages" > > But it's not that easy in respect to the guest reusing the pages. > > "previously hinted pages and not reused pages" ? > > Also, something like > > "The device MUST NOT modify the contents of previously hinted pages in > case they are reused by the devices, even if they are reused by the > driver before the hinting request is processed." "reused by the driver" in the first instance of course. -- Thanks, David / dhildenb
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]