Re: [RFC PATCH v2 1/2] Add virtio Admin Virtqueue specification

[Stefan Hajnoczi <stefanha@redhat.com>]

On Mon, Aug 02, 2021 at 05:58:19PM +0300, Max Gurtovoy wrote:
> 
> On 8/2/2021 5:34 PM, Cornelia Huck wrote:
> > On Mon, Aug 02 2021, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > 
> > > On Sun, Aug 01, 2021 at 02:46:13AM +0300, Max Gurtovoy wrote:
> > > > On 8/1/2021 1:17 AM, Michael S. Tsirkin wrote:
> > > > > On Sat, Jul 31, 2021 at 02:53:45PM +0300, Max Gurtovoy wrote:
> > > > > > On 7/30/2021 10:36 AM, Michael S. Tsirkin wrote:
> > > > > > > On Thu, Jul 29, 2021 at 05:51:07PM +0300, Max Gurtovoy wrote:
> > > > > > > > On 7/28/2021 3:48 PM, Michael S. Tsirkin wrote:
> > > > > > > > > On Mon, Jul 26, 2021 at 07:52:53PM +0300, Max Gurtovoy wrote:
> > > > > > > > > > Admin virtqueues will be used to send administrative commands to
> > > > > > > > > > manipulate various features of the device which would not easily map
> > > > > > > > > > into the configuration space.
> > > > > > > > > > 
> > > > > > > > > > The same Admin command format will be used for all virtio devices. The
> > > > > > > > > > Admin command set will include 4 types of command classes:
> > > > > > > > > > 1. The generic common class
> > > > > > > > > > 2. The transport specific class
> > > > > > > > > > 3. The device specific class
> > > > > > > > > > 4. The vendor specific class
> > > > > > > > > > 
> > > > > > > > > > The above mechanism will enable adding various features to the virtio
> > > > > > > > > > specification, e.g.:
> > > > > > > > > > 1. Format virtio-blk devices in various configurations (512B block size,
> > > > > > > > > >        512B + 8B T10-DIF, 4K block size, 4k + 8B T10-DIF, etc..).
> > > > > > > > > > 2. Live migration management.
> > > > > > > > > > 3. Encrypt/Decrypt descriptors.
> > > > > > > > > > 4. Virtualization management.
> > > > > > > > > > 5. Get device error logs.
> > > > > > > > > > 6. Implement advanced vendor/device/transport specific features.
> > > > > > > > > > 7. Run device health test.
> > > > > > > > > > 8. More.
> > > > > I still don't really see what do all these things have in common?
> > > > I don't think you need to look on this in that direction.
> > > > 
> > > > This is a queue for administration.
> > > > 
> > > > Cornelia and Stefan already agreed on this approach.
> > > We're discussing these patches and I'm trying to understand what you're
> > > proposing. It's a bit early to say I've agreed to anything.
> > For the record, same for me.
> 
> didn't you agree on admin q approach ?
> 
> I'm not talking about the command set.

I like the idea of a common admin virtqueue but it's still necessary to
answer questions that have been raised. If someone identifies a
significant issue or suggests an alternative then that needs to be dealt
with on its technical merit.

Stefan

Attachment: signature.asc
Description: PGP signature