Re: [virtio-comment] [PATCH] virtio-rpmb: fix the description for multi-block reads

[Alex BennÃe <alex.bennee@linaro.org>]

Cornelia Huck <cohuck@redhat.com> writes:

> On Mon, Aug 02 2021, Alex BennÃe <alex.bennee@linaro.org> wrote:
>
>> Cornelia Huck <cohuck@redhat.com> writes:
>>
>>> On Thu, Jul 22 2021, Alex BennÃe <alex.bennee@linaro.org> wrote:
>>>
>>>> Previously the text said we fail if block count is set to 1 despite
>>>> language elsewhere in the text referring to:
>>>>
>>>>   "For RPMB read request, one virtio buffer including request command
>>>>   and the subsequent [block_count] virtio buffers for response data
>>>>   are placed in the queue."
>>>>
>>>> and the existence of both max_wr_cnt and max_rd_cnt configuration
>>>> variables certainly implying devices should be able to handle
>>>> multi-block reads just like writes.
>>>>
>>>> Fix the description as well as format the steps as an enumerated list
>>>> to match the style of the previous section describing write handling.
>>>>
>>>> Reported-by: Ruchika Gupta <ruchika.gupta@linaro.org>
>>>> Signed-off-by: Alex BennÃe <alex.bennee@linaro.org>
>>>> ---
>>>>  virtio-rpmb.tex | 24 +++++++++++++-----------
>>>>  1 file changed, 13 insertions(+), 11 deletions(-)
>>>
>>> Do you want to request a vote for this?
>>
>> Sure - I think it's a clarification rather than a "new" feature but
>> whatever is needed to get it merged ;-)
>
> Yes, I think it is slightly over the line of things I would merge as an
> editorial update, so please open a github issue.

Done:

  https://github.com/oasis-tcs/virtio-spec/issues/113

-- 
Alex BennÃe