Re: [virtio-comment] RE: [virtio-dev] [PATCH v7] virtio-net: support inner header hash

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/2/2 äå11:55, Parav Pandit åé:
> > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > open.org> On Behalf Of Michael S. Tsirkin
> > Sent: Wednesday, February 1, 2023 1:57 AM
> > > Also, this patch is adding two functionalities.
> > > 1. Inner header hash calculation of existing already defined hash
> > > types 2. outer header hash for new type for GRE,VXLAN,GENEVE.
> > > #1 should be in 1st patch.
> > > #2 should be in 2nd patch.
> > > This is better to review.
> > Parav, you come to this discussion pretty late. Asking to split up the patch when
> > it's v1/v2 is ok. Asking after others have already reviewed v6 is not you are
> > making review easier for yourself but re-review harder for others who already
> > have a mind map of the patch.
> >
> > In this case unless we really want to enable these separately (and frankly I don't
> > see a good reason to) then splitting it up makes review more confusing.
> No. There is no need to enable it separately.
> It was hard to parse new inner type decoding addition which has close to zero relation to outer headers.
>
> As you say, it has some history, I don't have strong opinion to split.
> But going forward in subsequent work, it is better to see logical changes in multiple patches.

It seems that we don't need to emphasize the outer header hash, which is the
same behavior as usual when the inner header hash is not raised.

Thanks.