[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ
If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ feature should be negotiated. --- v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already out and doesn't include this depencency. v3: Explain the dependency in a less confusing way. Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com> device-types/net/description.tex | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/device-types/net/description.tex b/device-types/net/description.tex index 700a1cb..1741c79 100644 --- a/device-types/net/description.tex +++ b/device-types/net/description.tex @@ -256,6 +256,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device \field{duplex} fields as long as VIRTIO_NET_S_LINK_UP is set in the \field{status}. +The device SHOULD NOT offer VIRTIO_NET_F_HASH_REPORT if it +does not offer VIRTIO_NET_F_CTRL_VQ. + \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout} A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it. @@ -289,6 +292,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device SHOULD re-read \field{speed} and \field{duplex} after a configuration change notification. +A driver SHOULD NOT negotiate VIRTIO_NET_F_HASH_REPORT if it +does not negotiate VIRTIO_NET_F_CTRL_VQ. + \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout} \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout} When using the legacy interface, transitional devices and drivers -- 2.34.1
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]