[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation
On Tue, Feb 07, 2023 at 04:40:56PM +0200, Alvaro Karsz wrote: > > Arguably it's true. > > It will all be up to the committee vote of course ... > > To keep things a bit safer how about we just allow commands > > without qid instead of a special qid value? > > Also if we are going to change things how about adding a query command too? > > > > Also Alvaro what is your take on whether the gloabal version counts > > packets and time for all queues together or per queue? The spec > > does not make it clear ATM. > > My intention was for it to be global, mirroring ethtool coalescing parameters. > The notification coalescing section doesn't mention virtqueues, but it > is not directly mentioned that these are global parameters. An example of a question is this: we have two RX queues say 1 and 2 each with a distinct interrupt vector. coalescing is set to 10 packets. Now 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an interrupt? If yes which one - 1 or 2 or both? -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]