Re: [virtio-comment] [PATCH v3] virtio-net: Improve introductory description

[David Edmondson <david.edmondson@oracle.com>]

On Thursday, 2023-02-09 at 12:45:09 UTC, Parav Pandit wrote:
>> From: David Edmondson <david.edmondson@oracle.com>
>> Sent: Thursday, February 9, 2023 7:03 AM
>> 
>
> [..]
>> > +to the Ethernet network. The device has transmit and receive queues.
>> > +The driver posts empty buffers in the receive virtqueue.
>> > +The device receives the incoming packets from the link; the device
>> > +places these incoming packets in the receive virtqueue buffers.
>> > +The driver enqueues outgoing packets to the transmit virtqueue. The
>> >  device
>> 
>> We "post" receive buffers, yet "enqueue" transmit buffers. These actions seem
>> the same.
>> 
>> Maybe "submits" in both cases?
>> 
> At virtqueue level it is same.
> In context of virtio net device, transmit operation is queued that awaits processing (to send) by device.
> While receive side, its unsolicited operation done by driver that doesn't await processing by device.
> Whenever/if in future when a packet arrives, the posted buffer is consumed.
>
> So enqueue and post were capturing this contextual detail.
> But maybe I am trying to be too precise here but above wording were more natural to me at net level. :)
> Let me know..

I'm not too bothered. The operations are functionally the same, so using
different words seemed odd.
-- 
Please don't stand so close to me.