Re: [virtio-comment] [PATCH v2] virtio-net: support the virtqueue coalescing moderation

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/2/10 äå6:16, Alvaro Karsz åé:
> > > > So, should we remove VIRTIO_NET_F_CTRL_VQ here, or fix VIRTIO_NET_F_HOST_ECN?
> > > Ah good point.
> > > But I think  VIRTIO_NET_F_VQ_NOTF_COAL should not depend on VIRTIO_NET_F_NOTF_COAL.
> > > This way devices can drop the all-rx/all-tx commands if they want to.
> > We need to confirm this. If we make VIRTIO_NET_F_VQ_NOTF_COAL
> > independent of VIRTIO_NET_F_NOTF_COAL,
> > do we need to give vqn a special value so that the driver can also have
> > the fast path of sending all queues with global settings via
> > VIRTIO_NET_F_VQ_NOTF_COAL?
> IMO we don't need a special vqn value.
> A device that can modify all the vqs should offer VIRTIO_NET_F_NOTF_COAL.

That's clear, thanks for the quick reply.
Have a great weekend!