OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [PATCH] content.tex Fix Driver notifications label


On Wed, Feb 15 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Wed, Feb 15, 2023 at 01:19:25PM +0100, Cornelia Huck wrote:
>> On Wed, Feb 15 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> 
>> > On Fri, Feb 10, 2023 at 12:23:14PM +0100, Cornelia Huck wrote:
>> >> On Fri, Feb 03 2023, Parav Pandit <parav@nvidia.com> wrote:
>> >> 
>> >> > Driver notifications section is under "Basic Facilities of a Virtio
>> >> > Device". However, the label is placed under "Virtqueues" section.
>> >> >
>> >> > Fix the label references.
>> >> >
>> >> > Signed-off-by: Parav Pandit <parav@nvidia.com>
>> >> > ---
>> >> >  content.tex | 14 +++++++-------
>> >> >  1 file changed, 7 insertions(+), 7 deletions(-)
>> >> 
>> >> Not sure if it was originally intended to sit unter the virtqueues
>> >> section (it was lifted up one level as it disappeared under the packet
>> >> ring section), might have been.
>> >> 
>> >> It probably makes sense to not try and move it back into the virtqueues
>> >> section, and instead do your change. Other opinions?
>> >
>> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> > Minor fix does not need a vote.
>> > Cornelia are you applying this?
>> 
>> Pushed.
>
> btw did you try to generate a diff pdf? when changing labels it is
> sometimes necessary to keep old ones around too as diff
> needs old and new links to work.

I'm at least not seeing obvious errors.



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]