[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] Re: [PATCH v4] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature
Hi Heng, > > +When the device has non-zero \field{usecs} and non-zero \field{max_packets}, it starts counting usecs and packets upon receiving/sending a packet. > > +The device counts packets and usecs for each receive virtqueue and transmit virtqueue separately. > > +In this case, the notification conditions are met when \field{usecs} usecs elapses, or upon sending/receiving \field{max_packets} packets, whichever happens first. > > + > > Hi, Alvaro. > > "when \field{usecs} usecs elapses" --> "when \field{usecs} elapses", right? Actually, no. \field{usecs} refers to the field in the struct. usecs refers to the units of measurement. So if for example \field{usecs} = 40, then it evaluates to 40 usecs -> "are met when 40 usecs elapses". I can change the field name in the struct to "max_usecs" if people think it's necessary.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]