OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-dev] [PATCH v3] virtio-net: support the virtqueue coalescing moderation



> From: Heng Qi <hengqi@linux.alibaba.com>
> Sent: Thursday, February 16, 2023 9:49 AM


> Hi Michael.
> 
> I know you suggested in v2 that I split the virtqueue SET and GET commands in
> series, but I have a bit of a problem trying to split because there are some
> statements where SET and GET are glued together.
> Please see the following places.
> 
> If you think the split is better, I'll split it again and send it right away.

I agree with Michael, better to split.

It should be possible.
First patch without next patch consideration.
Second patch can modify the previous line, this is fine.
Its common practice and better even if it touches some of the same lines.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]