Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v8] virtio-net: support inner header hash

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/2/18 äå12:24, Parav Pandit åé:
> > From: virtio-dev@lists.oasis-open.org <virtio-dev@lists.oasis-open.org> On
> > Behalf Of Heng Qi
> [..]
>
> > We assume that hash_report_tunnel_types is still present in the next version,
> I am little lost.

Hi, Parav.

You are not lost. I'm just answering some of Michael's questions and 
making assumptions. :)

> I thought we all agreed that reporting just the tunnel type in data path path virtio_net_hdr is not useful to sw.
> And hence we should omit in the virtio_net_hdr.
>
> Did I miss the motivation to add it back?
> If not, probably it is better to review and discuss v9 without it, which will be easier to discuss.
>
> > but it only exists in virtio net hdr and should be populated by the device after
> > the hash calculation. hash_tunnel_types already controls whether the device
> > computes internal header hashes.
> >
> > > > I don't really follow this, hash_report_tunnel_type is better off
> > > > keeping it "report" literally.
> > >
> > > Talking about VIRTIO_NET_F_HASH_TUNNEL here. Not
> > > hash_report_tunnel_type.