Re: [virtio-dev] Re: [PATCH] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit

[Cornelia Huck <cohuck@redhat.com>]

On Mon, Feb 20 2023, Alvaro Karsz <alvaro.karsz@solid-run.com> wrote:

> I didn't add the control vq feature as a feature bit requirement for
> the same reason as [1].
>
> If you think that we can add a feature bit requirement instead of
> "SHOULD NOT offer" and "SHOULD NOT negotiate", I can add it in v2.
>
> [1] https://github.com/oasis-tcs/virtio-spec/issues/158

I agree that we need to stick with SHOULD here.

Are VIRTIO_NET_F_CTRL_RX_EXTRA and VIRTIO_NET_F_CTRL_RX independent of
each other, i.e. can you negotiate VIRTIO_NET_F_CTRL_RX_EXTRA but not
VIRTIO_NET_F_CTRL_RX? Looks like it to me, but would like to confirm.
(We would at most be able to add a SHOULD statement anyway.)