Re: [virtio-dev] Re: [PATCH v5] virtio-net: support the virtqueue coalescing moderation

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/2/21 äå7:48, David Edmondson åé:
> On Tuesday, 2023-02-21 at 16:38:52 +08, Heng Qi wrote:
> > ...
> > +A device MAY set the coalescing parameter to a value close to a power of 2 value.
> What is this about?
>
> If it is intended to indicate that a device may use a value different to
> that passed by the driver, more text to describe that would be

Yes. How about adding the following explanation to the "Operation" 
subparagraph?
"
When a device receives the VIRTIO_NET_CTRL_NOTF_COAL commands to set an 
coalescing parameter, it may set the parameter to a value close to a 
power of 2. For example:
If the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with \field{max_usecs} = 
7 is received, the device may set \field{max_usecs} = 8 for a given 
enabled virtqueue.
"

Thanks.

> useful. If not, what does it mean?