RE: [virtio-dev] [PATCH v2] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit

[Parav Pandit <parav@nvidia.com>]

> From: virtio-dev@lists.oasis-open.org <virtio-dev@lists.oasis-open.org> On
> Behalf Of Alvaro Karsz
> 
> The VIRTIO_NET_F_CTRL_RX_EXTRA feature bit is mentioned in the spec since
> version 1.0, but it's not properly defined.
> 
> This patch defines the feature bit and defines the dependency on
> VIRTIO_NET_F_CTRL_VQ.
> 
> Since this dependency is missing in previous versions, we add it now as a
> "SHOULD".
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/162
> 
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> ---
> v2:
> 	- Rephrase commit log, no changes to patch body.
> 
>  device-types/net/description.tex | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 8487ccd..cf37da5 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -74,6 +74,8 @@ \subsection{Feature bits}\label{sec:Device Types /
> Network Device / Feature bits
> 
>  \item[VIRTIO_NET_F_CTRL_VLAN (19)] Control channel VLAN filtering.
> 
> +\item[VIRTIO_NET_F_CTRL_RX_EXTRA (20)]	Control channel RX extra
> mode support.
> +
>  \item[VIRTIO_NET_F_GUEST_ANNOUNCE(21)] Driver can send gratuitous
>      packets.
> 
> @@ -259,6 +261,9 @@ \subsection{Device configuration
> layout}\label{sec:Device Types / Network Device  The device SHOULD NOT
> offer VIRTIO_NET_F_HASH_REPORT if it  does not offer
> VIRTIO_NET_F_CTRL_VQ.
> 
> +The device SHOULD NOT offer VIRTIO_NET_F_CTRL_RX_EXTRA if it does not
> +offer VIRTIO_NET_F_CTRL_VQ.
> +
>  \drivernormative{\subsubsection}{Device configuration layout}{Device Types /
> Network Device / Device configuration layout}
> 
>  A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
> @@ -295,6 +300,9 @@ \subsection{Device configuration
> layout}\label{sec:Device Types / Network Device  A driver SHOULD NOT
> negotiate VIRTIO_NET_F_HASH_REPORT if it  does not negotiate
> VIRTIO_NET_F_CTRL_VQ.
> 
> +A driver SHOULD NOT negotiate VIRTIO_NET_F_CTRL_RX_EXTRA if it does not
> +negotiate VIRTIO_NET_F_CTRL_VQ.
> +
>  \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device
> Types / Network Device / Device configuration layout / Legacy Interface: Device
> configuration layout}  \label{sec:Device Types / Block Device / Feature bits /
> Device configuration layout / Legacy Interface: Device configuration layout}
> When using the legacy interface, transitional devices and drivers
> --
> 2.34.1

Reviewed-by: Parav Pandit <parav@nvidia.com>