Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/2/28 äå3:49, Michael S. Tsirkin åé:
> On Tue, Feb 28, 2023 at 10:41:18AM +0800, Heng Qi wrote:
> > > The problem is the global qualifier. And it's not even global -
> > > there are two sets for rx and for tx and does not apply to cvq at all.
> > > How about "RX/TX coalescing parameters"?
> > As Parav suggested, we probably don't need to mention "global
> > values/coalescing parameters" since this values/parameters are the ones set
> > by CTRL_NOTF_COAL_RX/TX_SET.
> >
> > Just like this:
> > "
> > After disabling and re-enabling a virtuqueue, the device MUST revert to
> > coalescing parameters to the one configured using VIRTIO_NET_CTRL_NOTF_COAL.
> > "
> >
> > Thanks.
> VIRTIO_NET_CTRL_NOTF_COAL is not a thing. Let's wait for Alvaro's new
> patch to be merged though, see what teminology he comes up with and
> reuse.

Ok, are you referring to Alvaro's "virtio-net: Fix and update 
VIRTIO_NET_F_NOTF_COAL feature",
if so I see that his v7 version is stable and has been voted in 
https://github.com/oasis-tcs/ virtio-spec/issues/159 ,
this patch was made on top of his v7 version.

Thanks.