[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number
On Thu, 02 Mar 2023 16:06:52 +0100 Cornelia Huck <cohuck@redhat.com> wrote: > > And then for extra fun, in the RSS section we say "0 based index" where we > > seem to mean "this number in the queue name, but subtract 1 in your head". > > Why subtract 1? I guess we wanted these 5 year olds to practice math ... > > Heh :) > > Yeah, that looks like a mess... I don't think we should use a weird > substraction scheme. I haven't looked at the RSS stuff much, would it be > hard to fix it up? I just did. I wrote a somewhat lengthy email on that. The TL;DR is: we should probably rename the receive and transmit queues (receiveq1 should become receiveq0 and receiveqN should becaome receiveqN-1 for N > 0). Regards, Halil
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]