[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number
On Thu, Mar 09, 2023 at 05:46:50PM +0100, Halil Pasic wrote: > To uniquely identify an element we need both the index (a value) and > the array/table that is being indexed. And I believe this is what we > need to improve on. I don't think calling indexes into the conceptual > array of receive queues (or receive virtqueues) "index of the receive > virtqueue", indexes into the conceptual array of virtqueues that belong > to a certain device a "vq number", indexes into the descriptor table > "descriptor keys", and indexes into the used rings "used ring element > ids" would really help -- to make an attempt at using reduction ad > absurdum ;) Right. I think Parav said he's converting everything to just refer to "VQ number". > > > > I feel there's less of a chance of a confusion between VQ size and > > its number. But it's not a strong prefrence, RSS is relatively young > > and it's the only incompatible user of index so far. > > I don't understand why is RSS incompatible with "index". > > Regards, > Halil It uses the word "index" in a way that is different from what you suggest. Anyway, both "number" and "index" require cleanup work, whoever is going to do it gets to decide which way it will go. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]