Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/3/15 äå8:10, Michael S. Tsirkin åé:
> On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote:
> > If not, for now it may be better to skip vxlan and nvegre as they inherently
> > have unique outer header UDP src port based on the inner header.
> So what's left, GRE?  GRE is actually different, in that it's not IP at
> all.

I do not think so, I mentioned that VXLAN and GENEVE need inner 
symmetric hashing, and we need this.

And we know inner hashing doesn't conflict with other ways of adding 
entropy.

Thanks.

> So if we are talking about GRE, hash is indeed not calculated at all at
> the moment, right?  And I would say a natural first step for GRE is
> actually adding a hash type that will support this protocol.
>
> How about doing that? It seems like this should be a small step
> and completely uncontroversial.