RE: [virtio-comment] [PATCH v2 1/7] transport-pci: Refer to the vq by its number

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, March 21, 2023 5:01 AM
> 
> \item[\field{queue_notify_data}]
>         This field exists only if VIRTIO_F_NOTIF_CONFIG_DATA has been
> negotiated.
>         The driver will use this value to put it in the 'virtqueue number' field
>         in the available buffer notification structure.
> 
> and I think it's actually \field{vqn} not 'virtqueue number':
> 	\item [vqn] VQ number to be notified.
>
Yes. will fix this in v3.
 
> and it also says
> 
>         In a trivial case the device can set \field{queue_notify_data}=vqn. Some
> devices
>         may benefit from providing another value, for example an internal
> virtqueue
>         identifier, or an internal offset related to the virtqueue number.
> 
> and that's backwards since vqn is always queue_notify_data.
> What is meant is "set queue_notify_data to the virtqueue number'.

Yes this change too in v3.