[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [PATCH v3 6/8] transport-ccw: Refer to the vq by its number
> From: Michael S. Tsirkin <mst@redhat.com> > Sent: Tuesday, March 21, 2023 6:22 PM > > +\begin{note} > > +\field{queue_select} was previously named as index. > > sounds a bit strange, and \field{} is missing. If you insist I'd say > in previous versions of this specification, > field{queue_select} was also called queue \field{index} > The field is missing because field index is no longer there. > > e.g. in blk we have this: > In the legacy interface, VIRTIO_BLK_F_FLUSH was also > called VIRTIO_BLK_F_WCE. > > > but I really feel this misses the point, the compat is needed > in the struct definition, not split out after usage > is described. This is why I proposed just making this a comment in the > struct. Why not? > Sure comment is good to me too. In v0 you specifically asked to add note with example. You said "like "Note: this was previously known as QueueNumMax"" It is hard to guess to write a comment when you mean "Note". :) I will change to comment format.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]