RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation

[Parav Pandit <parav@nvidia.com>]

> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Wednesday, March 22, 2023 11:21 AM
> 
> On Wed, Mar 22 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:
> 
> > +The driver MUST NOT set \field{vqn} to any value other than an enabled
> transmit or receive virtqueue number.
> 
Why do you suggest a negative statement here?
How is it better than,
The driver MUST set ...

The device will anyway have to check and apply the parameter to the right virtqueue.
And if the vq is not enabled or vq is not tx or rx vq, it needs to fail the command.

> "than the virtqueue number of an enabled transmit or receive virtqueue"
> 
> might be better -- what do others think?
> 
> Otherwise, LGTM.