Re: [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number

[Stefano Garzarella <sgarzare@redhat.com>]

On Mon, Mar 27, 2023 at 01:41:33PM +0000, Parav Pandit wrote:
> Hi Stefano,
>
> > From: Stefano Garzarella <sgarzare@redhat.com>
> > Sent: Monday, March 27, 2023 6:04 AM
>
> > Maybe we can also remove `index` from the last sentence in this section.
> > I mean something like this:
> >
> > --- a/transport-mmio.tex
> > +++ b/transport-mmio.tex
> > @@ -113,8 +113,8 @@ \subsection{MMIO Device Register
> > Layout}\label{sec:Virtio Transport Options / Vi
> >       following operations on \field{QueueSizeMax},
> >       \field{QueueSize}, \field{QueueReady},
> >       \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow},
> > \field{QueueDriverHigh},
> > -    \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> > apply to. The index
> > -    number of the first queue is zero (0x0).
> > +    \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> > apply to.
> > +    The number of the first queue is zero (0x0).
> >     }
> >     \hline
> >     \mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{%
> >
> > Thanks,
> > Stefano
> With Michael suggestion, the first patch describes the vq number range.

I see.

> I think we can drop this duplicate text from here all together.

Yep, I agree on that.

Thanks,
Stefano