[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [virtio-comment] [PATCH v8 5/8] transport-ccw: Rename queue depth/size to other transports
> From: David Edmondson <david.edmondson@oracle.com> > Sent: Tuesday, March 28, 2023 10:07 AM > > --- a/transport-ccw.tex > > +++ b/transport-ccw.tex > > @@ -237,12 +237,12 @@ \subsubsection{Configuring a > > Virtqueue}\label{sec:Virtio Transport Options / Vir > > \begin{lstlisting} struct vq_config_block { > > be16 index; > > - be16 max_num; > > + be16 max_queue_size; /* Previously named as max_num */ > > "named as" doesn't feel like typical language use - you can remove "as", though > I'd be inclined to use some kind of decoration for the name: > > /* Previously named 'max_num'. */ > > > }; > > \end{lstlisting} I really don't see any value in putting this change log material in the spec section, But anyways, Michael finds its useful for some users, So how about, /* Previously known as max_num. */
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]