OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number


On Mon, Apr 03, 2023 at 10:57:35PM -0400, Parav Pandit wrote:
> I see few options.
> 
> Option_1:
> 1. I will send v12 of this series to use index all the places instead of
> number.
> 2. driver notification structure vqn to rename to vq_notify_id.
> (after merging this series as follow up cleanup).

We can pretend that vqn means "VQ Notification".  Backronims are fun.
In fact it is not always a vq index, sometimes it's a different value.
So maybe keeping vqn there makes sense.


> 3. Once interrupt moderation series is merged, rename vqn to vq_index.
> (really vqn reads better even though history say vq index).
> Because votes is completed and voting period ended for the important
> feature.

It's ongoing but sure, we can do a fix up on top.

> 4. Michael send v12 with index.

Of AQ? Sure.

> Option_2:
> 1. Continue with the v11 of this series as vq number.
> 2. Continue with interrupt moderation series voted
> 3. Continue with Michael's work of AQ
> 4. Will do #2 of option_1.
> 
> Please decide at earliest.
>

It looks like the sentiment is now going more option 1.
If you like post v12 and we'll see which gets more acks.

-- 
MST



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]