Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation

[Heng Qi <hengqi@linux.alibaba.com>]

å 2023/4/11 äå4:05, Cornelia Huck åé:
> On Thu, Mar 23 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:
>
> > Hi all! If after reviewing it you feel it meets the necessary
> > requirements, I kindly request a vote.
> >
> > Thanks a lot!
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/166
> So this has been voted upon and accepted, but we have further discussion
> downthread.
>
> Should we merge the voted-upon version now and do further changes on
> top, or wait for the discussion to conclude first so that we can merge
> all of it in one go?
Hi, Cornelia.

According to Parav's excellent patch set work on "rename" I tracked and 
Halil and Michael's discussion,
the discussion is about vqn-> vq_notify_id, queue_notify_data-> 
queue_notify_id, virtqueue number->virtqueue index in the *Notifications 
chapter*;
in *MMIO Device Register Layout chapter*, QueueNum->QueueSize.
Thanks Parav for his respectable work and the reviewer's comments, which 
made the spec clearer.

We left the virtqueue number/index of RSS and virtqueue coalescing (this 
work) parts unchanged as suggested by Halil.
Please correct me if my trace missed something.

Thanks.