Re: [PATCH v13 08/11] transport-ccw: Refer to the vq by its index

[Halil Pasic <pasic@linux.ibm.com>]

On Tue, 11 Apr 2023 22:23:38 +0300
Parav Pandit <parav@nvidia.com> wrote:

> Currently specification uses virtqueue index and
> number interchangeably to refer to the virtqueue.
> 
> Instead refer to it by its index.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

> ---
> changelog:
> v11->v12:
> - removed changes related to index
> - replace number with index
> - added 'only' to make it more clear that
>   notification has only vq index
> v9->v10:
> - replaced queue_select with vqn
> - used lower case letter for first word in comment
> v8->v9:
> - replaced 'named' with 'known'
> - replaced 'queue number' with 'vq number'
> v3->v4:
> - moved note to comment
> v2->v3:
> - added comment note for queue_select similar to max_queue_size
> v0->v1:
> - new patch
> ---
>  transport-ccw.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/transport-ccw.tex b/transport-ccw.tex
> index cb476c7..86272d1 100644
> --- a/transport-ccw.tex
> +++ b/transport-ccw.tex
> @@ -545,7 +545,7 @@ \subsubsection{Guest->Host Notification}\label{sec:Virtio Transport Options / Vi
>  \end{tabular}
>  
>  When VIRTIO_F_NOTIFICATION_DATA has not been negotiated,
> -the \field{Notification data} contains the Virtqueue number.
> +the \field{Notification data} contains the virtqueue index.
>  
>  When VIRTIO_F_NOTIFICATION_DATA has been negotiated,
>  the value has the following format: