OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH] device-types/multiple: replace queues with enqueues


> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Wednesday, April 19, 2023 9:33 AM
> 
> On Tue, Apr 11 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> > Queue is a verb and noun both. Replacing it with enqueue avoids
> > ambiguity around plural queues noun vs verb; similar to virtio fs
> > device description.
> 
> Personally, I don't think this patch adds much, but I don't really mind it, either.
> 
> >
> > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> >  device-types/blk/description.tex   | 2 +-
> >  device-types/gpio/description.tex  | 4 ++--
> >  device-types/i2c/description.tex   | 2 +-
> >  device-types/scsi/description.tex  | 2 +-
> > device-types/vsock/description.tex | 2 +-
> >  5 files changed, 6 insertions(+), 6 deletions(-)
> >
> 
> (...)
> 
> > diff --git a/device-types/vsock/description.tex
> > b/device-types/vsock/description.tex
> > index 105bb30..07909d6 100644
> > --- a/device-types/vsock/description.tex
> > +++ b/device-types/vsock/description.tex
> > @@ -218,7 +218,7 @@ \subsubsection{Buffer Space
> > Management}\label{sec:Device Types / Socket Device /  \field{buf_alloc} and
> \field{fwd_cnt} fields.
> >
> >  \subsubsection{Receive and Transmit}\label{sec:Device Types / Socket
> > Device / Device Operation / Receive and Transmit} -The driver queues
> > outgoing packets on the tx virtqueue and incoming packet
> > +The driver enqueues outgoing packets on the tx virtqueue and incoming
> > +packet
> 
> "queues (...) on" reads natural to me, but I'd use "to" with "enqueues"... 
Yes, I agree.
The driver enqueues outgoing packets to the tx virtqueue reads better to me.

> can any
> native speakers comment?
> 
> >  receive buffers on the rx virtqueue. Packets are of the following form:
> >
> >  \begin{lstlisting}



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]