OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description



> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, April 19, 2023 7:27 AM
> 
> On Wed, Apr 19, 2023 at 04:25:13PM +0800, Zhu, Lingshan wrote:

> > > > +        The driver writes an MSI-X vector number here for Configuration
> change
> > > > +        interrupts.
> > > Hmm I think it's "the vector", not an. And the order of words is
> > > unusual. We also don't normally use "writes here". Would
> > >
> > > 	Used by the driver to set the MSI-X vector number for Configuration
> change interrupts.
> > >

To keep the text consistent with rest of the fields and to address below comment about MSI-X table entry reference,

As:
The driver writes the MSI-X table entry index in this field for Configuration change notification interrupts.

Similar to,
The driver writes this to accept feature bits offered by ...


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]