[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH 1/2] transport-pci: Improve config msix vector description
On Thu, Apr 20, 2023 at 10:51:57PM +0300, Parav Pandit wrote: > config_msix_vector is the register that holds the MSI-X vector number > for receiving configuration change related interrupts. > > It is not "for MSI-X". > > Hence, replace the confusing text with appropriate one. > > Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com> > Signed-off-by: Parav Pandit <parav@nvidia.com> it's unfortunate that the pci spec does not have a standard term for msi-x table entry. > --- > changelog: > v1->v2: > - rewrote to indicate MSI-X table entry index > v0->v1: > - added 'here' > - dropped 'receiving' > --- > transport-pci.tex | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/transport-pci.tex b/transport-pci.tex > index 1507c69..cf2c54d 100644 > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -343,7 +343,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport > Driver Feature Bits selected by \field{driver_feature_select}. > > \item[\field{config_msix_vector}] > - The driver sets the Configuration Vector for MSI-X. > + The driver writes the MSI-X table entry index in this field for > + Configuration change notification interrupts. Urm not exactly. there is also a special value of 0xffff. I feel this here is just a high level description. how about Used by the driver to set the MSI-X vector for Configuration change notification interrupts. pci spec also calls the entry "the vector" so I feel it's ok. > \item[\field{num_queues}] > The device specifies the maximum number of virtqueues supported here. > -- > 2.26.2 > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]