OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH 2/2] admin: Make optional command data type to u8



> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, May 2, 2023 3:38 AM
> Thanks for the patch. It was like this originally but readers were confused.  The
> point of marking it le64 is to make it clear it's size is a multiple of 8 bytes, thus
> 64 bits. And format of fields inside it is generally LE.

If it is supposed to be le64, the result should be same data type too, isn't it?

> 
> > ---
> >  admin.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/admin.tex b/admin.tex
> > index 037e2e6..648253c 100644
> > --- a/admin.tex
> > +++ b/admin.tex
> > @@ -85,7 +85,7 @@ \subsection{Group administration
> commands}\label{sec:Basic Facilities of a Virti
> >          /* unused, reserved for future extensions */
> >          u8 reserved1[12];
> >          le64 group_member_id;
> > -        le64 command_specific_data[];
> > +        u8 command_specific_data[];
> >
> >          /* Device-writable part */
> >          le16 status;
> > --
> > 2.26.2



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]