Re: RE: [PATCH] transport-fabrics: introduce Virtio Over Fabrics

[zhenwei pi <pizhenwei@bytedance.com>]

On 5/4/23 04:54, Parav Pandit wrote:
> > From: zhenwei pi <pizhenwei@bytedance.com>
> > Sent: Wednesday, May 3, 2023 8:58 AM
> >
> > In the past years, virtio supports lots of device specifications by
> > PCI/MMIO/CCW. These devices work fine in the virtualization environment.
> >
> > Introduce Virtio Over Fabrics transport to support "network defined peripheral
> > devices". With this transport, Many Virtio based devices transparently work
> > over fabrics. Note that the balloon device may not make sense. Shared memory
> > regions won't work.
>
> Before getting in the details of the 1000+ lines of text, lets please have some basic protocol set as it is unlikely going to conclude with one patch.
>
> 1. Please version your patches as "PATCH v0" -> PATCH v1" etc.
> 2. add change log of major items changed/removed/added, so reviewer can focus on those at priority while ignoring existing things from vN to vN+1.
>
> 3. Split giant 1000+ lines of text to smaller incremental patches.
>
> An example for this would be,
> a. overview of fabrics
> b. Theory of operation
> c. descriptor structures
> d. device/transport Notifications
> e. Queue connect/disconnect commands
> f. control path commands (get/set features etc)
> g. data transfer commands and responses
> h. conformance sections

OK, I'll send a v2 version later.
Thanks!

--
zhenwei pi