[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v2 08/11] transport-fabrics: introduce status of completion
On Thu, May 04, 2023 at 04:19:07PM +0800, zhenwei pi wrote: > Define status of completion, currently status 0-114 has the same > meaning to the linux error code, because these status are used for > many years, they are clear and friendly to linux system developers > (even for other platform developers). > > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com> > --- > transport-fabrics.tex | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/transport-fabrics.tex b/transport-fabrics.tex > index 026ff5f..f563c3e 100644 > --- a/transport-fabrics.tex > +++ b/transport-fabrics.tex > @@ -838,3 +838,38 @@ \subsubsection{Opcodes Definition}\label{sec:Virtio Transport Options / Virtio O > > virtio_of_op_set_config is used to set the config of a device for control queue only. > The initiator MUST issue a \nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Commands Definition / Config Command} with specified offset and bytes and value fields. > + > +\subsubsection{Status Definition}\label{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Status Definition} > +This section defines status for Virtio Over Fabrics Completion. > + > +\begin{lstlisting} > +#define VIRTIO_OF_SUCCESS 0 > +#define VIRTIO_OF_EPERM 1 > +#define VIRTIO_OF_ENOENT 2 > +#define VIRTIO_OF_EIO 5 > +#define VIRTIO_OF_ENXIO 6 > +#define VIRTIO_OF_E2BIG 7 > +#define VIRTIO_OF_ENOMEM 12 > +#define VIRTIO_OF_EACCES 13 > +#define VIRTIO_OF_EFAULT 14 > +#define VIRTIO_OF_EBUSY 16 > +#define VIRTIO_OF_EEXIST 17 > +#define VIRTIO_OF_ENODEV 19 > +#define VIRTIO_OF_EINVAL 22 > +#define VIRTIO_OF_ERANGE 34 > +#define VIRTIO_OF_ENOSYS 38 > +#define VIRTIO_OF_ECHRNG 44 > +#define VIRTIO_OF_EUNATCH 49 > +#define VIRTIO_OF_EBADE 52 > +#define VIRTIO_OF_EBADR 53 > +#define VIRTIO_OF_EBADRQC 56 > +#define VIRTIO_OF_ENODATA 61 > +#define VIRTIO_OF_EPROTO 71 > +#define VIRTIO_OF_EBADMSG 74 > +#define VIRTIO_OF_ENOTUNIQ 76 > +#define VIRTIO_OF_EREMCHG 78 > +#define VIRTIO_OF_EUSERS 87 > +#define VIRTIO_OF_EOPNOTSUPP 95 > +#define VIRTIO_OF_EALREADY 114 > +#define VIRTIO_OF_EQUIRK 4096 > +\end{lstlisting} Errnos convey little meaning and make it hard to troubleshoot failures. Please define specific status codes instead so the initiator knows exactly what is wrong instead of just EINVAL, EIO, etc. Stefan
Attachment:
signature.asc
Description: PGP signature
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]