Re: Re: [virtio-comment] [PATCH v2 10/11] transport-fabrics: add device initialization

[zhenwei pi <pizhenwei@bytedance.com>]

On 6/1/23 05:09, Stefan Hajnoczi wrote:
> On Thu, May 04, 2023 at 04:19:09PM +0800, zhenwei pi wrote:
> > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> > ---
> >   transport-fabrics.tex | 24 ++++++++++++++++++++++++
> >   1 file changed, 24 insertions(+)
> >
> > diff --git a/transport-fabrics.tex b/transport-fabrics.tex
> > index c47a744..af35622 100644
> > --- a/transport-fabrics.tex
> > +++ b/transport-fabrics.tex
> > @@ -882,3 +882,27 @@ \subsubsection{TCP}\label{sec:Virtio Transport Options / Virtio Over Fabrics / r
> >   \subsubsection{RDMA}\label{sec:Virtio Transport Options / Virtio Over Fabrics / ransport Binding / RDMA}
> >   RDMA MUST use \ref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Commands Definition / Keyed Transmission}
> >   ~\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Commands Definition / Keyed Transmission}.
> > +
> > +\subsection{Device Initialization}\label{sec:Virtio Transport Options / Virtio Over Fabrics / Device Initialization}
> > +\begin{enumerate}
> > +\item The control queue MUST be established firstly, once the reliable
>
> It's not 100% clear whether the control queue must be established first
> and then the other things happen, or whether the other things have to
> happen in order to establish the control queue.
>
> Here is one way to reword it:
>
> "The control queue MUST be established first by connecting from the
> initiator to the target and sending a \nameref{sec:Virtio Transport
> Options / Virtio Over Fabrics / Transmission Protocol / Opcodes
> Definition / virtio_of_op_connect} command to create the association
> with the target."
>
> > +connection is ready, the initiator MUST issue
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_connect}
> > +to create association with the target.
> > +\item The initiator SHOULD issue
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_get_feature}
> > +to discover the capabilities offered by the target.
> > +\item The initiator SHOULD issue
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_set_feature}
> > +to negotiate the capabilities.
> > +\item The initiator SHOULD continue initialization like PCI base devices, i.e. issue
>
> Please use a \nameref to reference to something specific in the spec. It
> would be even better to list the exact steps here instead of referring
> to the PCI Transport.
>
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_get_vendor_id}
> > +to get the vendor ID.
> > +\item After discovering the number of virtqueues by
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_get_num_queues},
> > +the initiator SHOULD create virtqueue one by one by
>
> "virtqueues one by one with"
>
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_connect}.
> > +\item The virtqueue SHOULD issue
>
> "The initiator SHOULD issue"
>
> > +\nameref{sec:Virtio Transport Options / Virtio Over Fabrics / Transmission Protocol / Opcodes Definition / virtio_of_op_vring}
> > +to transmit buffer.
>
> "to supply available buffers to the device"

OK, will fix above flaws.

> > +\end{enumerate}
> > --
> > 2.25.1
> >
> >
> > This publicly archived list offers a means to provide input to the
> > OASIS Virtual I/O Device (VIRTIO) TC.
> >
> > In order to verify user consent to the Feedback License terms and
> > to minimize spam in the list archive, subscription is required
> > before posting.
> >
> > Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> > List help: virtio-comment-help@lists.oasis-open.org
> > List archive: https://lists.oasis-open.org/archives/virtio-comment/
> > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> > Committee: https://www.oasis-open.org/committees/virtio/
> > Join OASIS: https://www.oasis-open.org/join/

--
zhenwei pi