[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-comment] [PATCH requirements 4/7] net-features: Add notification coalescing requirements
On Fri, Jun 02, 2023 at 01:03:02AM +0300, Parav Pandit wrote: > Add virtio net device notification coalescing improvements requirements. > > Signed-off-by: Parav Pandit <parav@nvidia.com> > --- > net-workstream/features-1.4.md | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/net-workstream/features-1.4.md b/net-workstream/features-1.4.md > index 054f951..fc36f31 100644 > --- a/net-workstream/features-1.4.md > +++ b/net-workstream/features-1.4.md > @@ -8,6 +8,7 @@ together is desired while updating the virtio net interface. > # 2. Summary > 1. Device counters visible to the driver > 2. Low latency tx and rx virtqueues for PCI transport > +3. Virtqueue notification coalescing re-arming support > > # 3. Requirements > ## 3.1 Device counters > @@ -143,3 +144,10 @@ struct vnet_rx_completion { > 7. The device should be able to indicate when a full page buffer is consumed, > which can be recycled by the driver when the packets from the completed > page is fully consumed. > + > +## 3.3 Virtqueue notification coalescing re-enable support > +1. Tx and Rx virtqueue notification coalescing should auto-disable on > + notification reporting to the driver. The driver should be able to enable > + coalescing after processing the packets per VQ. This ensures that when > + networking stack decides to poll, no new notifications are generated when > + per VQ notification coalescing is used. Weirdly specific. I don't know what does auto-disable and enable coalescing mean. Does this refer to VIRTIO_NET_F_NOTF_COAL? what is the problem this is trying to solve? > -- > 2.26.2 > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]