Re: [virtio-dev] Re: [PATCH v3 0/3] transport-pci: Introduce legacy registers access using AQ

[Jason Wang <jasowang@redhat.com>]

On Thu, Jun 8, 2023 at 10:38âPM Parav Pandit <parav@nvidia.com> wrote:
>
>
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Wednesday, June 7, 2023 2:54 AM
>
> > Hypervisor can trap the legacy device configuration space write and convert it
> > to cvq commands.
> Michael already answered that cvq is not trapped; this is the main design goal we talked several times that it is passthrough device.

Is this really a blocker? Wouldn't a new feature(_F_LEFACY_MAC) or cap
resolve this?

>
> So no point discussing this again.
>
> If you have any comments on v4, please let me know.
>
> Both the design points are addressed in v4.
> 1. To split to two commands for device and config area
> 2. Use pci cap to learn about notification region
>
> Since this ABI reflects what we agree on,

I think not since you fail to explain why this approach is better than
simply adding new features like _F_LEGACY_HEADER and _F_LEGACY_MAC.

Thanks

> I would want to raise for vote in coming days to be part of 1.3 in few days as we have more than 3 weeks to sort out non-ABI language part.