Re: RE: About custom device counter

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Tue, 13 Jun 2023 01:57:39 +0000, Parav Pandit <parav@nvidia.com> wrote:
>
>
> > From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > Sent: Monday, June 12, 2023 2:13 AM
> >
> > We hope to support device custom counter. That is, virtio spec provides a
> > channel for driver and device, and both key and value are provided by device.
> >
> > We discussed this issue earlier, and after some internal practice, I think it is still
> > necessary to discuss this again.
> >
> > It is very important, each cloud vendor will always have some special counters,
> > these counters may not exist in another vendor. At the same time, if we have to
> > discuss it in the spec every time we add a counter, or add a feature, I think it is
> > very inconvenient. Manufacturers may add some new counters at any time
> > based on some new requirements. Some counters may also be removed at any
> > time.
> >
> Debug counters are useful to have.
> I agree that they may be vendor specific.
> We often try to abstract and define as much as vendor neutral as possible.
>
> So we should probably first put our efforts to see if more than one vendor can use it.

I agree.

>
> Assuming there is some vendor specific counters, I imagine to come from a separate vendor specific query command.
> This is to keep standard counters to avoid mixing with vend_specific.

Yes, I agree that these are two separate channels.

But I don't think we need to wait for the first job to finish.

It is conceivable that standard counters will be displayed on ethtool in the
future. For counters from different manufacturers, we can display them in
/sys/class/net/eth0/vendor_couters.

Here we can tell the user that these are only for the current device, and may
change during the migration process.


>
> > Of course I know that doing this might hurt migration. But what I want to say is,
> > why does it affect live migration? These counters we plan to give to users
> > through ethtool -S, and some changes have taken place in the ethtool counters
> > output by users. Does this have any practical impact? Or do we directly use
> > some other output in a way, we can clearly tell the user that these counters may
> > change during the migration process. For example, the driver is migrated to
> > some new devices. These devices support some new counters. I think users
> > should be able to see these new counters. These new counters may be the
> > purpose of the migration.
>
> Counters which are well defined non-vendor specific should be able to migrate to destination on best effort basis.
> For well defined counters if device A at src support N counters, on migrated destination, it should be N.
> This should be able to achieve with feature provisioning infra via group owner command.

Yes, for standard counters.

>
> >
> > We don't need to support live migration at this point.
> When done on best effort level, infra exists, vendor has ability to incrementally implement it.


For the standard counters, the manufacturer will be very willing to use it. I
just want to introduce the capabilities of the manufacturer's customized.

Thanks.