Re: [PATCH v6 3/4] admin: Add group member legacy register access commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Jun 19, 2023 at 04:29:43PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Monday, June 19, 2023 12:21 PM
> 
> > > diff --git a/admin-cmds-legacy-access.tex
> > > b/admin-cmds-legacy-access.tex new file mode 100644 index
> > > 0000000..89a4f49
> > > --- /dev/null
> > > +++ b/admin-cmds-legacy-access.tex
> > > @@ -0,0 +1,138 @@
> > > +\subsubsection{Legacy Interfaces: legacy configuration access
> > > +commands}\label{sec:Basic Facilities of a Virtio Device / Device
> > > +groups / Group administration commands / Legacy Interfaces: legacy
> > > +configuration access commands}
> > 
> > I think this is where all the theory of operation text should go.
> >
> This is where most of the theory of operation is documented which is agnostic of the transport.
> PCI specific things are left in pci transport section.

what I am saying is that it's cleaner here at least for now.

> > > +
> > > +The group owner device can optionally enable the driver to access its
> > > +member devices legacy common configuration and device configuration
> > > +region
> > 
> > we can just say "the legacy interface of member devices"
> > 
> What is the harm in telling explicitly what is currently supported, specially when it theory of operation description section.

The harm is that
- making things generic on the 1st try is the only stick we have
  as contributors always push to make their solutions as
  specific to their needs as possible
- people are lazy and they will copy text and then
I get to repeat this argument all over again.

If you want to also have a type specific text, be my guest
"specifically, for an SRIOV type" .... 


> > > using following listed
> > 
> > using the following
> > 
> > > +administrative commands:
> > 
> > administration not administrative
> > 
> Ack.