OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash


> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, June 21, 2023 3:36 PM
> 
> It can be helpful for debugging. E.g. if driver sets a bit that device does not
> recognize, it can figure out that driver has it set in supported mask.
Device is reporting error code anyway when it receives a unexpected command contents.

> Or if it seems like a waste we can just ask drivers to put 0 there, works for me
> too.

I fail to see this being any better or equal to two structures.

> 
> 
> > Two structures are cleaner.
> 
> Frankly what's cleaner is what RSS is doing, supported mask in config space.
> Was this discussed in some version? I don't remember.
> 
Yes, we discussed. 



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]