RE: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

[Parav Pandit <parav@nvidia.com>]

> From: Heng Qi <hengqi@linux.alibaba.com>
> Sent: Thursday, June 22, 2023 9:43 AM
> 
> Yes, I think we also have to consider upcoming
>  ÂÂÂ 1. device counters (e.g. supported_device_counter),
>  ÂÂÂ 2. receive flow filters (e.g. supported_flow_types, supported_max_entries),
>  ÂÂÂ 3. header splits (e.g. supported_split_types) etc.
> Continuous expansion of the configuration space needs to be careful.
> 
> >
> > Instead of decision point being RO vs RW, any new fields via cmdvq and
> > existing fields stays in cfg space, give predictable behavior to size the member
> devices in the system.
> > Once the cmdvq is available, we can get rid of GET command used in this
> version for new future features.
> > Till that arrives, GET command is the efficient way.
> 
> Yes, I agree.
> 
> Thanks.

Right. So, Miachel main concern was two vs one struct.
And given the GET and SET works on different fields, having two structure is just fine.
The code is fairly small.
I donât see any real issue here with v18.