Re: [PATCH v8 0/4] admin: Access legacy registers using admin commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jul 04, 2023 at 01:26:20PM +0000, Parav Pandit wrote:
> Hi Michael,
> 
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Friday, June 30, 2023 12:20 AM
> > 
> > This short series introduces legacy registers access commands for the owner
> > group member access the legacy registers of the member VFs.
> > This short series introduces legacy region access commands by the group owner
> > device for its member devices.
> > Currently it is applicable to the PCI PF and VF devices. If in future any SIOV
> > devices to support legacy registers, they can be easily supported using same
> > commands by using the group member identifiers of the future SIOV devices.
> > 
> > More details as overview, motivation, use case are further described below.
> > 
> > Patch summary:
> > --------------
> > patch-1 split rows of admin opcode tables by a line
> > patch-2 fix section numbering
> > patch-3 add generic legacy region access commands
> > patch-4 add pci specific definition
> 
> [..]
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/167
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > 
> > ---
> > changelog:
> > v7->v8:
> > - remove empty line at the end of file
> > - removed white space at the end
> > - addressed comments from Michael add link to pci
> > - renamed region to region_data
> > - made region_data width to be 16 bytes to cover for 8 bytes offset
> > - moved generic notification region related normative from pci to
> >   generic section
> > - made bar offset 64-bit
> > - prefix legacy specific structure with _legacy
> > - moved generic normative from pci to generic section
> > - added link to virtio pci capabilities when referring to bar 0
> > - remove 'should' from generic description
> 
> Do you have any further comments on 3rd and 4th patch?
> I fixed your comments of v7, and some more were fixed.


Hope to send review tonight, max tomorrow.