RE: [PATCH v8 3/4] admin: Add group member legacy register access commands

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, July 4, 2023 6:17 PM
> To: Parav Pandit <parav@nvidia.com>
> Cc: virtio-comment@lists.oasis-open.org; cohuck@redhat.com;
> david.edmondson@oracle.com; virtio-dev@lists.oasis-open.org;
> sburla@marvell.com; jasowang@redhat.com; Yishai Hadas
> <yishaih@nvidia.com>; Maor Gottlieb <maorg@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>
> Subject: Re: [PATCH v8 3/4] admin: Add group member legacy register access
> commands
> 
> On Tue, Jul 04, 2023 at 10:15:34PM +0000, Parav Pandit wrote:
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Tuesday, July 4, 2023 6:01 PM
> > >
> > > In some systems, there's need to support utilizing legacy drivers
> > > with devices that do not directly support the legacy interface.
> > > In such scenarios, an owner device of a group can provide the legacy
> > > interface functionality for group members.
> > > The driver of an owner device can then access the legacy interface
> > > of a member device on behalf of the legacy member device driver.
> > >
> > In the last line, I will change from 'legacy member device driver' to just
> 'member device driver'.
> 
> I think it's important to stress legacy since normal driver that follows the spec
> does not access legacy interface at all.
> 
Alright.
Will keep legacy.

> 
> > I will fix rest of the comments including having pad bytes after offset and have
> similar changes in rest of the places.