RE: [virtio-dev] [PATCH v13] admin: Add group member legacy register access commands

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Monday, July 10, 2023 11:17 AM

> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Sunday, July 9, 2023 9:47 AM
> >
> >
> > > > +If within \field{struct
> > > > +virtio_admin_cmd_legacy_notify_info_result}
> > > > +returned by VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO, the
> > > > +\field{flags} value for a specific \field{struct
> > > > +virtio_pci_legacy_notify_info} entry is 0x0, the driver MUST
> > > > +ignore this entry and all the following \field{entries}.
> >
> > Please see above, it appears to me that it covers what you asked for, no?
> > What is missing?
> 
> Oh, my bad. I agree. following stresses this a bit more:
> 
> 
> is 0x0, then the driver MUST ignore this entry as well as all the following
> \field{entries} until the end of the structure.
> 
> 
> > > The driver MUST additionally validate, for each
> > > > +entry, that \begin{itemize} \item the \field{flags} is either
> > > > +0x0,
> > > > +0x1 or 0x2 \item the \field{bar} corresponds to a valid BAR of
> > > > +either the owner or the member device, depending on the
> > > > +\field{flags} \item the \field{offset} is 2-byte aligned and
> > > > +corresponds to an address within the BAR specified by the
> > > > +\field{bar} on \field{flags} \end{itemize}, any entry which does
> > > > +not meet these constraints MUST be ignored by the driver.
> > >
> > > Wait a second.
> > > - end of list not documented - we want conformance statements
> > > - for end of list I am guessing other fields do not matter
> > > - entries after end of list also do not matter?
> >
> > I reread the above driver conformance statement.
> > It already indicates what you asked.
> 
> So the above two do not contradict. They kind of seem to since 1st one says
> ignore second says validate, until you look closely and see that the result of
> validation is to ignore.
> I suggest we clarify it's other entries not each entry:
> 
> 	MUST ignore this entry and all the following \field{entries}.
> 
> 	Additionally, for all other entries, the driver MUST validate
> 	that \begin{itemize} \item the \field{flags} is either
> 	0x1 or 0x2  ....
Sounds good. Revising it.