Re: [virtio-comment] [PATCH requirements v4 1/7] net-features: Add requirements document for release 1.4

[David Edmondson <david.edmondson@oracle.com>]

On Tuesday, 2023-08-15 at 09:11:18 UTC, Parav Pandit wrote:
>> From: David Edmondson <david.edmondson@oracle.com>
>> Sent: Tuesday, August 15, 2023 2:26 PM
>
>
>> > +4. If a virtio device is group member device, a group owner should be able
>> > +   to query all the counter attributes using the administration command
>> which
>> > +   a virtio member device will expose via a virtqueue to the driver.
>> 
>> The language seems confusing here. How about:
>> 
>> If a virtio device is a group member device, it must be possible to query all of
>> the group member counter attributes via the group owner device.
>> 
>> > +4. If a virtio device is a group member device, a group owner should be able
>> > +   to query all of the member device counter attributes and counters via the
>> > +   group owner device.
>> 
>> Similarly:
>> 
>> If a virtio device is a group member device, it must be possible to query all of
>> the group member counters via the group owner device.
>> 
> I messed up this point 4 while addressing your comments from v3.
>
> How about,
>
> If a virtio device is a group member device, it must be possible to query supported counters bitmap through the group owner device.
> The group owner driver should be able to query such bitmap using administration command.
>
> Notice that group owner only cares for the supported bitmap, no need to query the counters through this interface.

Why do we think this is the case? It would be useful for a group owner
to be able to see the statistics as they are being reported to the
member consumer.

> With this we can reuse single structure across AQ and CVQ to learn about supported bitmap in v14 patch from Xuan.

Makes sense.
-- 
I'm not living in the real world, no more, no more.